Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Oct 27, 2025

quant_utils.py only have one public function, build_rescale, which in turn is only use by one file op_tosa_rescale.py. For this reason, move build_rescale into op_tosa_rescale.py and remove quant_utils.py.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

quant_utils.py only have one public function, `build_rescale`, which in
turn is only use by one file op_tosa_rescale.py. For this reason, move
`build_rescale` into op_tosa_rescale.py and remove quant_utils.py.

Signed-off-by: Martin Lindström <[email protected]>
Change-Id: I2a3564e60e1566979b0c3714d3b17cded91b61cd
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15392

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Cancelled Jobs, 2 Unrelated Failures

As of commit 4db72ed with merge base c85ece4 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 27, 2025
@martinlsm
Copy link
Collaborator Author

@digantdesai I think this PR needs approval from Meta since it removes a file.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

@digantdesai It might be nice if you could tests this with buck2 internally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants