Skip to content

Conversation

@shubham0204
Copy link

@shubham0204 shubham0204 commented Oct 25, 2025

Fixes #15125

Release notes: misc

Summary

  • Add implementation and test for a new factory method Tensor.ones() in the android extension

Test plan

The following new JUnit tests were added to verify the behavior of Tensor.ones() in extension/android/executorch_android/src/test/java/org/pytorch/executorch/TensorTest.kt

  • testOnes_DTypeIsFloat

cc @kirklandsign @cbilgin

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15388

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit 56ec76c with merge base 964515c (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2025
@shubham0204 shubham0204 marked this pull request as draft October 25, 2025 07:05
@shubham0204
Copy link
Author

@pytorchbot label "release notes: misc"

@pytorch-bot pytorch-bot bot added the release notes: misc Miscellaneous label Oct 25, 2025
@shubham0204 shubham0204 force-pushed the 15126-java-ones-zeros-tensor-constructors branch from 18e207f to 4c6d19d Compare October 25, 2025 08:11
@shubham0204 shubham0204 marked this pull request as ready for review October 25, 2025 08:12
@digantdesai digantdesai added the module: android Issues related to Android code, build, and execution label Oct 27, 2025
@digantdesai digantdesai requested review from kirklandsign and removed request for kirklandsign October 27, 2025 19:43
@GregoryComer GregoryComer requested a review from psiddh October 27, 2025 20:31
@GregoryComer
Copy link
Member

@shubham0204 Thanks for the contribution. Can you fix the java android lint and rebase the PR? If everything looks good, we can merge it shortly.

@shubham0204 shubham0204 force-pushed the 15126-java-ones-zeros-tensor-constructors branch from 4c6d19d to def5753 Compare November 5, 2025 12:53
@shubham0204
Copy link
Author

shubham0204 commented Nov 5, 2025

@GregoryComer I have fixed the Java formatting issues in the modified files. The formatting used is google-java-format as described suggested in the failing CI job. Also rebased the branch onto pytorch:main.

@shubham0204 shubham0204 force-pushed the 15126-java-ones-zeros-tensor-constructors branch from def5753 to 56ec76c Compare November 5, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: android Issues related to Android code, build, and execution release notes: misc Miscellaneous

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Zeros/Ones Tensor Constructor (Android)

4 participants