nvfp4: support inference_mode and rank 3 #3240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3240
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1e3d3e3 with merge base 53b5efd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Oct 24, 2025
Summary: Adds support for inference mode and rank 3 inputs for nvfp4 inference Test Plan: ``` pytest test/prototype/mx_formats/test_inference_workflow.py -s -x -k test_inference_workflow_nvfp4 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 459143d ghstack-comment-id: 3441037282 Pull-Request: #3240
meta-cla
bot
added
the
CLA Signed
vkuzo
added
the
topic: improvement
jerryzh168
reviewed
Oct 24, 2025
| ids=lambda s: f"{s[0]}x{s[1]}x{s[2]}", | ||
| ) | ||
| @pytest.mark.parametrize("use_inference_mode", [False, True]) | ||
| @pytest.mark.parametrize("x_rank", [2, 3]) |
There was a problem hiding this comment.
nit: maybe instead of x_rank, we can follow this:
ao/test/quantization/quantize_/workflows/float8/test_float8_tensor.py
Lines 76 to 77 in e9c7bea
jerryzh168
reviewed
Oct 24, 2025
jerryzh168
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for inference mode and rank 3 inputs for nvfp4 inference
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: