Skip to content

Support int8 output for scaled_embedding_bag #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Support int8 output for scaled_embedding_bag #3231

wants to merge 12 commits into from
+182 −54

Conversation

@shiyang-weng
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3231

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 33e3f0f with merge base f3fc5e7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shiyang-weng shiyang-weng marked this pull request as draft October 23, 2025 04:24
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025
@shiyang-weng shiyang-weng changed the title Wengshiy/int8 scaled embedding bag Support int8 output for scaled embedding bag Oct 23, 2025
@shiyang-weng shiyang-weng changed the title Support int8 output for scaled embedding bag Support int8 output for scaled_embedding_bag Oct 23, 2025
@shiyang-weng
Copy link
Contributor Author

@pytorchbot label "topic: new feature"

@pytorch-bot pytorch-bot bot added the topic: new feature Use this tag if this PR adds a new feature label Oct 24, 2025
@shiyang-weng
Copy link
Contributor Author

@Xia-Weiwen @mingfeima Could you help review this PR?

Xia-Weiwen
Xia-Weiwen reviewed Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@Xia-Weiwen Xia-Weiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor changes are needed.

@Xia-Weiwen
Copy link
Collaborator

CC @mingfeima for review. Thanks.

shiyang-weng and others added 3 commits October 24, 2025 09:52
@shiyang-weng @Xia-Weiwen
refine scale
0b5ade5 
Co-authored-by: Xia Weiwen <[email protected]>
@shiyang-weng @Xia-Weiwen
refine code
4f8bff0 
Co-authored-by: Xia Weiwen <[email protected]>
@shiyang-weng
refine code
33e3f0f
@shiyang-weng shiyang-weng marked this pull request as ready for review October 28, 2025 02:11
@shiyang-weng
Copy link
Contributor Author

@jerryzh168 Could you help review this pr?

@Xia-Weiwen Xia-Weiwen requested a review from jerryzh168 October 28, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xia-Weiwen Xia-Weiwen Xia-Weiwen approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

+1 more reviewer

@mingfeima mingfeima mingfeima approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: new feature Use this tag if this PR adds a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shiyang-weng @Xia-Weiwen @mingfeima