-
Notifications
You must be signed in to change notification settings - Fork 358
[mxfp8 moe training] bench and profile mxfp8 a2a fwd and bwd separately #3203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+78
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3203
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danielvegamyhre
added a commit
that referenced
this pull request
Oct 17, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
2ab06e3 to
da3608b
Compare
This was referenced Oct 17, 2025
da3608b to
e6959d4
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Oct 17, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
e6959d4 to
19a4679
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Oct 17, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
vkuzo
approved these changes
Oct 28, 2025
danielvegamyhre
added a commit
that referenced
this pull request
Oct 28, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
19a4679 to
9b576ec
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Oct 28, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
9b576ec to
767d725
Compare
0824320 to
79d9918
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Oct 28, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
767d725 to
ed4963c
Compare
79d9918 to
bae2b76
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Oct 28, 2025
stack-info: PR: #3203, branch: danielvegamyhre/stack/81
7e52c7e to
63db07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
moe
mx
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[mxfp8 moe training] bench and profile mxfp8 a2a fwd and bwd separately
Single node benchmark on 4xB200 over NVLink shows perf is flat or slightly slower in this setting.
BF16 forward:

MXFP8 forward:

TL;DR is the transfer of the fp8 data is ~1.72x faster than the bf16 data, but the extra overhead of e8m0 scale transfer, quantization and dequantization all adds up to make the perf flat/slower.
Next steps
to_mxfp8_then_scaled_grouped_mmto optionally accept scales (pre-quantized tensors)