Skip to content

Adding rank based logging for torch distributed examples #3897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: abose/trt_llm_installation_dist
Choose a base branch
from
Open

Adding rank based logging for torch distributed examples #3897

wants to merge 1 commit into from
+180 −41

Conversation

@apbose
Copy link
Collaborator

@apbose apbose commented Nov 14, 2025

This PR

  1. Adds rank based logging for the distributed examples
  2. Corrects the fallback to pytorch case for NCCL converters
  3. This with Changes to TRT-LLM download tool for multigpu distributed case  #3830 provides utilities for running distributed tensor parallel examples using torch.distributed

@meta-cla meta-cla bot added the cla signed label Nov 14, 2025
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 14, 2025
@apbose apbose changed the title Adding rank based logging for torch distributed examples. Also correc… Adding rank based logging for torch distributed examples Nov 14, 2025
@github-actions github-actions bot requested a review from narendasan November 14, 2025 00:05
@apbose apbose marked this pull request as draft November 14, 2025 00:05
@apbose apbose changed the title Adding rank based logging for torch distributed examples Adding rank based logging for torch distributed examples[WIP] Nov 14, 2025
@apbose apbose force-pushed the abose/trt_llm_installation_changes_debug branch from 31666e3 to 52ae92a Compare November 25, 2025 22:59
@apbose apbose changed the title Adding rank based logging for torch distributed examples[WIP] Adding rank based logging for torch distributed examples Nov 26, 2025
@apbose apbose marked this pull request as ready for review November 26, 2025 00:28
@apbose apbose changed the base branch from main to abose/trt_llm_installation_dist November 26, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan Awaiting requested review from narendasan

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apbose