Skip to content

support prefetch pipeline (#2045) #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

support prefetch pipeline (#2045) #5032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions fbgemm_gpu/fbgemm_gpu/tbe/ssd/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1984,12 +1984,13 @@ def _prefetch( # noqa C901
# Store info for evicting the previous iteration's
# scratch pad after the corresponding backward pass is
# done
self.ssd_location_update_data.append(
(
sp_curr_prev_map_gpu,
inserted_rows,
if self.training:
self.ssd_location_update_data.append(
(
sp_curr_prev_map_gpu,
inserted_rows,
)
)
)

# Ensure the previous iterations eviction is complete
current_stream.wait_event(self.ssd_event_sp_evict)
Expand Down Expand Up @@ -2173,7 +2174,7 @@ def _prefetch( # noqa C901

# Store scratch pad info for post backward eviction only for training
# for eval job, no backward pass, so no need to store this info
if self.training and not self._embedding_cache_mode:
if self.training:
self.ssd_scratch_pad_eviction_data.append(
(
inserted_rows,
Expand Down Expand Up @@ -4548,6 +4549,12 @@ def direct_write_embedding(
if len(self.ssd_scratch_pad_eviction_data) > 0:
self.ssd_scratch_pad_eviction_data.pop(0)
if len(self.ssd_scratch_pad_eviction_data) > 0:
# Wait for any pending backend reads to the next scratch pad
# to complete before we write to it. Otherwise, stale backend data
# will overwrite our direct_write updates.
# The ssd_event_get marks completion of backend fetch operations.
current_stream.wait_event(self.ssd_event_get)

# if scratch pad exists, write to next batch scratch pad
sp = self.ssd_scratch_pad_eviction_data[0][0]
sp_idx = self.ssd_scratch_pad_eviction_data[0][1].to(
Expand Down
Loading
Loading