Restrict filename parameter of compile() (and other stdlib functions wrapping compile()) to take bytes, not Buffer.
#14847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses to only take `bytes` instead of `Buffer` as path. These also route to `compile()`.
This comment has been minimized.
This comment has been minimized.
Sachaa-Thanasius
changed the title
compile() (and other stdlib functions that use compile()) to only take bytes, not Buffer.compile() (and other stdlib functions wrapping compile()) to take bytes, not Buffer.
…tes instead of Buffer as path.
This comment has been minimized.
This comment has been minimized.
|
I'd say we shouldn't bother with the different version_info branches. Just use the more restrictive option. The possibility of someone using a non-bytes readable buffer and not wanting to fix it for Python < 3.12 are low, and I don't have much sympathy. |
|
Fair enough. |
…lib_external.pyi).
|
Diff from mypy_primer, showing the effect of this PR on open source code: altair (https://github.com/vega/altair)
+ altair/utils/execeval.py:81: error: Argument "filename" to "compile" has incompatible type "str | Buffer | PathLike[Any]"; expected "str | bytes | PathLike[Any]" [arg-type]
+ altair/utils/execeval.py:87: error: Argument "filename" to "compile" has incompatible type "str | Buffer | PathLike[Any]"; expected "str | bytes | PathLike[Any]" [arg-type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13881.
Maybe
warnings.deprecated()could be used here to deprecate non-bytes buffers as arguments, but I wanted to be initially conservative in the number of overloads this adds.