Skip to content

docs(proposals): Deprecate PEP 508 Direct References (req.url)#1225

Open
smoparth wants to merge 1 commit into
mainfrom
docs/deprecate-req-url
Open

docs(proposals): Deprecate PEP 508 Direct References (req.url)#1225
smoparth wants to merge 1 commit into
mainfrom
docs/deprecate-req-url

Conversation

@smoparth

@smoparth smoparth commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Propose deprecating the package @ git+https://... syntax in favor of the declarative source provider config. The feature requires 19 special-case branches across 6 files and every use case is covered by the new git-clone providers (pypi-git, github-tag-git, gitlab-tag-git, versionmap-git).

Pull Request Description

What

Why

@smoparth smoparth requested a review from a team as a code owner July 2, 2026 14:57
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This change adds a new architecture decision record proposing deprecation and eventual removal of PEP 508 direct reference URL (req.url) support as a top-level bootstrap input. It defines scope limits, maps req.url use cases to declarative source provider configuration, and outlines a three-phase plan: emit deprecation warnings, provide migration guidance, and remove special-case code paths. No code or public API changes are included.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Sequence Diagram(s)

No diagram generated, as this change is a documentation-only addition with no code flow to depict.

Related issues: None mentioned in the provided context.

Related PRs: None mentioned in the provided context.

Suggested labels: documentation, proposal

Suggested reviewers: None specified.

🐰 A note is penned, no code to see,
Just plans for URLs' future decree,
"req.url", we bid adieu,
Sources will guide us through,
A rabbit's scroll of things to be.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: deprecating PEP 508 direct references (req.url).
Description check ✅ Passed The description is directly about deprecating req.url in favor of declarative source providers.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rd4398

rd4398 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This aligns with what we discussed earlier today. @dhellmann originally added this feature and we should wait for him to take a look and see what he thinks.

@rd4398 rd4398 requested a review from dhellmann July 2, 2026 15:07
@tiran

tiran commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Nit-pick: We don't use the term "ADR" in upstream Fromager.

…(req.url)

Propose deprecating the `package @ git+https://...` syntax in favor
of the declarative `source` provider config. The feature requires 19
special-case branches across 6 files and every use case is covered by
the new git-clone providers (pypi-git, github-tag-git, gitlab-tag-git,
versionmap-git).

Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>
@smoparth smoparth force-pushed the docs/deprecate-req-url branch from 3e4eda9 to 4f97bed Compare July 6, 2026 14:42
@smoparth smoparth deployed to release July 6, 2026 14:42 — with GitHub Actions Active
@smoparth smoparth changed the title docs(proposals): add ADR to deprecate PEP 508 direct references (req.url) docs(proposals): Deprecate PEP 508 Direct References (req.url) Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants