fix(testing): pytest.approx
returns a clearer error mesage when comparing mappings with different keys
#13818
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes an issue with
pytest.approx
where the error message was not clear when comparing mappings with different keys. Previously, the comparison would proceed and report-inf
mismatches on values or aKeyError
, leading to confusing error messages.The fix adds an early check in
ApproxMapping
to compare the sets of keys between the expected and actual mappings. If they differ, it returns a clear error message indicating the different keys.This closes #13816.
Checklist
changelog
folder, named<ISSUE NUMBER>.<TYPE>.rst
.