Fix Elemwise inside OpFromGraph in numba mode #1774
+44
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Dec 5, 2025
| for v in chain.from_iterable(s for s in input_shapes if s is not None): | ||
| # Import input_shape nodes, as for some graphs ShapeFeature assumes these were seen before | ||
| if (node := v.owner) is not None: | ||
| fgraph.import_node(node, import_missing=True) |
Member
Author
There was a problem hiding this comment.
ShapeFeature is quite picky about having seen some variables. It may even count as bug but I don't want to open that can of worms.
Anyway OpFromGraph uses this helper for infer_shape, and the way Blockwise triggers it when it has an OFG inside, would end up triggering an error.
ricardoV94
commented
Dec 5, 2025
| scalar_shape = {create_tuple_string(shape_var_item_names)} | ||
| {check_runtime_broadcast_src} | ||
| res = np.empty(scalar_shape, dtype=val.dtype) | ||
| res = np.empty(scalar_shape, dtype=np.{dtype}) |
Member
Author
There was a problem hiding this comment.
This would fail for scalar valued alloc due to numba/numba#10358
ricardoV94
force-pushed
the
OpFromGraph
branch
from
c76e524 to
e187a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from #811
Closes #1507
Also added a somewhat semantically related commit for an Alloc failure inside a Blockwise