Implemented icdf for Categorical distribution and add shape/broadcasting tests. #7920
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ricardoV94
reviewed
Oct 13, 2025
| def icdf(value, p): | ||
| eps = 1e-12 | ||
| q = value | ||
| q_safe = pt.clip(q, 0.0, 1.0 - eps) |
There was a problem hiding this comment.
I don't see why we need q_safe?
Comment on lines
+1209
to
+1210
| mask = pt.shape_padright(q_safe, 1) <= cdf | ||
| idx = pt.argmax(mask, axis=-1).astype("int64") |
Comment on lines
+1205
to
+1207
| extra = q_ndim - cdf_batch_ndim | ||
| axes = list(range(cdf.ndim - 1)) + ["x"] * extra + [cdf.ndim - 1] | ||
| cdf = cdf.dimshuffle(axes) |
There was a problem hiding this comment.
Use expand_dims for readability
|
Thanks for opening the PR @iTzZe4lous I left some comments above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
icdfimplementation topymc/distributions/discrete.py.test_categorical_icdf,test_categorical_icdf_batch_shapes, andtest_categorical_icdf_upper_edge.Testing
pytest -q tests/distributions -k categorical).Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7920.org.readthedocs.build/en/7920/