Skip to content

Conversation

@samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • undeprecate select_columns and select_rows
  • deprecate filter_column_isin
  • update register_groupby_method to register_dataframe_groupby_method

This PR resolves #1514.

Please tag maintainers to review.

@samukweku samukweku self-assigned this Nov 23, 2025
@samukweku samukweku linked an issue Nov 23, 2025 that may be closed by this pull request
@ericmjl
Copy link
Member

ericmjl commented Nov 23, 2025

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question to address.

from janitor.functions.select import get_index_labels


@pf.register_groupby_method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samukweku are we sure this is to be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericmjl yes, this has been replaced with @pf.register_dataframe_groupby_method -> @pf.register_dataframe_groupby_method

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, @samukweku I probably should have been clearer in my phrasing -- I noticed that the whole ungroup function was deleted, is this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the observation @ericmjl ... I have updated the code to show that ungroup is deprecated.

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving!

@ericmjl
Copy link
Member

ericmjl commented Dec 6, 2025

@samukweku please do the honors!

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.78%. Comparing base (e1b64c1) to head (3461a99).
⚠️ Report is 73 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1532      +/-   ##
==========================================
+ Coverage   83.49%   87.78%   +4.29%     
==========================================
  Files          88       95       +7     
  Lines        6469     6794     +325     
==========================================
+ Hits         5401     5964     +563     
+ Misses       1068      830     -238     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samukweku samukweku merged commit 951d244 into dev Dec 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undeprecate select_columns and select_rows

3 participants