-
Notifications
You must be signed in to change notification settings - Fork 177
undeprecate select columns and select rows #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undeprecate select columns and select rows #1532
Conversation
|
🚀 Deployed on https://deploy-preview-1532--pyjanitor.netlify.app |
ericmjl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick question to address.
janitor/functions/mutate.py
Outdated
| from janitor.functions.select import get_index_labels | ||
|
|
||
|
|
||
| @pf.register_groupby_method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samukweku are we sure this is to be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericmjl yes, this has been replaced with @pf.register_dataframe_groupby_method -> @pf.register_dataframe_groupby_method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, @samukweku I probably should have been clearer in my phrasing -- I noticed that the whole ungroup function was deleted, is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the observation @ericmjl ... I have updated the code to show that ungroup is deprecated.
ericmjl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving!
|
@samukweku please do the honors! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1532 +/- ##
==========================================
+ Coverage 83.49% 87.78% +4.29%
==========================================
Files 88 95 +7
Lines 6469 6794 +325
==========================================
+ Hits 5401 5964 +563
+ Misses 1068 830 -238 🚀 New features to boost your workflow:
|
PR Description
Please describe the changes proposed in the pull request:
select_columnsandselect_rowsfilter_column_isinThis PR resolves #1514.
Please tag maintainers to review.