Skip to content

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 12, 2025

No description provided.

@bitprophet
Copy link
Member

This is already fixed on main, actually, and for other reasons, 2.0 is a bit outside my supported branches window (yes this is ironic given recent social media threads 😅). If you rebase this on 2.1 tho I'll happily merge it so any future 2.1/2.2 releases have a slightly less crusty readme! Thanks!

@bitprophet
Copy link
Member

Also, a bunch of related modernizations are happening as we speak, in a branch, so look out for that.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 13, 2025

This is already fixed on main, actually,

Yeah, I saw main was fixed but was a bit confused why PyPI was different before realising it's the release branches.

and for other reasons, 2.0 is a bit outside my supported branches window

I wasn't sure which were supported so followed https://www.pyinvoke.org/development.html#submitting-bug-reports-or-patches which points to https://www.contribution-guide.org/ which says to target the "oldest supported release line".

It would be helpful to name the supported branches at https://www.pyinvoke.org/development.html. Shall I open a PR to say it's only 2.1 and 2.2? Would this docs PR only go to main?

(yes this is ironic given recent social media threads 😅)

:D

If you rebase this on 2.1 tho I'll happily merge it so any future 2.1/2.2 releases have a slightly less crusty readme!

Coming up!

@hugovk hugovk changed the base branch from 2.0 to 2.1 October 13, 2025 15:54
@bitprophet
Copy link
Member

This is already fixed on main, actually,

Yeah, I saw main was fixed but was a bit confused why PyPI was different before realising it's the release branches.

FWIW I just now pushed the real serious business modernization update to main. all pyproject all the time baybeeee

It would be helpful to name the supported branches at https://www.pyinvoke.org/development.html.

It would be helpful! Unfortunately, I'm basically doing this half-assed thing where that sliding window is ~=1-2 release lines from whatever is most recent, and having it enshrined in the docs would be kind of annoying to keep updated (at least in the ideal world where I am releasing with any speed, last couple years things stalled out for Life Reasons).

Just updated contribution-guide.org to clarify that somewhat, with the mild epiphany "just tell 'em to look at the changelog, that'll make it obvious" 💡

However that's not building because it, too, bitrotted, so hey! another line item for my upgrading checklist. will get on that shortly, you can see the commit here if you wanna thumbs up/down the language: bitprophet/contribution-guide.org@22a591b

@hugovk
Copy link
Contributor Author

hugovk commented Oct 13, 2025

FWIW I just now pushed the real serious business modernization update to main. all pyproject all the time baybeeee

Exciting! 🎈🚀🎈

will get on that shortly, you can see the commit here if you wanna thumbs up/down the language: bitprophet/contribution-guide.org@22a591b

Looks good! 👍

@bitprophet bitprophet merged commit 3718b60 into pyinvoke:2.1 Oct 13, 2025
2 of 3 checks passed
@bitprophet
Copy link
Member

Thanks, all set and merged up. Also merging-up a tweak to CI config to not try building on modern Pythons, so if I do any more backporting this far, it doesn't automatically fail those jobs.

But, given the nature of things, probably won't backport to 2.1+ much unless we find security issues - next minor or major release will have all the fixins and be a simpler merge target again.

@hugovk hugovk deleted the patch-2 branch October 13, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants