feat: make docker.image idempotent #1492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker.image(...)` will now check if the image exist and only pull when required. It uses the following logic for this: 1. If `force == True` it will always pull the image 2. If an exact digest is provided, it will pull if there is no image with the same registry + repo + name + digest 3. If a tag is provided and the tag is `latest`, it will always pull 4. If a tag is provided and it is not `latest`, it will pull if no image exists with the same registry + repo + name + tag It offloads most of this logic to Docker itself, by relying on the `DockerImage` fact, which in turn uses `docker image inspect` to figure out if an image with name + tag or digest exists.
DonDebonair
force-pushed
the
feat/docker-image-idempotent
branch
from
f53e0f9 to
a251eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker.image(...)will now check if the image exist and only pull when required. It uses the following logic for this:force == Trueit will always pull the imagelatest, it will always pulllatest, it will pull if no image exists with the same registry + repo + name + tagIt offloads most of this logic to Docker itself, by relying on the
DockerImagefact, which in turn usesdocker image inspectto figure out if an image with name + tag or digest exists.3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)