Skip to content

Update renderview.js#199

Merged
almarklein merged 2 commits intomainfrom
renderview
Mar 25, 2026
Merged

Update renderview.js#199
almarklein merged 2 commits intomainfrom
renderview

Conversation

@almarklein
Copy link
Member

@almarklein almarklein commented Mar 25, 2026

The renderview.js now has its own home at https://github.com/pygfx/renderview. It defines the event spec (formerly jupyter_rfb event spec) as well as the JS implementation. It also has a tester there, so we can make improvements there, and then copy the source to rendercanvas and jupyter_rfb.

In the new event spec, some fields were renamed. The idea is to propagate these changes into rendercanvas as well, but in small steps, while keeping things backwards compatible.

The new JS code also has some small improvements that were added while working on the jupyter_rfb refactoring.

@almarklein almarklein marked this pull request as ready for review March 25, 2026 12:40
@almarklein
Copy link
Member Author

@Vipitis @Korijn I'm just moving forwards with these JS related PRs to keep up the pace. Feel free to comment also on merged PRs.

@almarklein almarklein merged commit 9112f0a into main Mar 25, 2026
21 checks passed
@almarklein almarklein deleted the renderview branch March 25, 2026 12:45
@Vipitis
Copy link
Contributor

Vipitis commented Mar 25, 2026

sure, I have been following the progress and even tried the new jupyter_rfb in vscode today - it works with fpl again! (although there might have been some issues with imgui and scrolling, will file issues if I find the time to investigate).

I have no js experience so I won't be able to comment much and I will be away the next two weeks, want to try getting the wgpu pyodide branch out of draft before that,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants