Merged
Conversation
Member
Author
Contributor
|
sure, I have been following the progress and even tried the new jupyter_rfb in vscode today - it works with fpl again! (although there might have been some issues with imgui and scrolling, will file issues if I find the time to investigate). I have no js experience so I won't be able to comment much and I will be away the next two weeks, want to try getting the wgpu pyodide branch out of draft before that, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
renderview.jsnow has its own home at https://github.com/pygfx/renderview. It defines the event spec (formerly jupyter_rfb event spec) as well as the JS implementation. It also has a tester there, so we can make improvements there, and then copy the source to rendercanvas and jupyter_rfb.In the new event spec, some fields were renamed. The idea is to propagate these changes into rendercanvas as well, but in small steps, while keeping things backwards compatible.
The new JS code also has some small improvements that were added while working on the jupyter_rfb refactoring.