Support multiple items in DataTree.__getitem__ and improve NodePath (renamed to TreePath) #10854
+355
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `NodePath` to `TreePath` to make its name slightly more obvious - Automatically normalize paths in the `TreePath` constructor - Use `joinpath()` and normalized tree paths to simplify implementations of `_get_item` and `_set_item`. None of these changes are user facing.
github-actions
bot
added
topic-backends
topic-zarr
shoyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for indexing with multiple items as a list of paths in
DataTree.__getitem__, e.g.,tree[['first', 'second']].It also includes internal improvements to
NodePath(now renamed toTreePath):NodePathtoTreePathto make its name slightly more obviousTreePathconstructorjoinpath()and normalized tree paths to simplify implementations of_get_itemand_set_item.