Skip to content

Simplify implementation of merge() for DataTree #10844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −13
Open

Simplify implementation of merge() for DataTree #10844

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8305a20
simplify implementation of merge() for DataTree
shoyer Oct 12, 2025
4fcf3bf
revert inadvertently included changes
shoyer Oct 12, 2025
1049058
fix merge_trees
shoyer Oct 12, 2025
d582c5e
Merge branch 'main' into simplify-merge
shoyer Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions xarray/structure/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ def merge_core(


def merge_trees(
trees: Iterable[DataTree],
trees: Sequence[DataTree],
compat: CompatOptions | CombineKwargDefault = _COMPAT_DEFAULT,
join: JoinOptions | CombineKwargDefault = _JOIN_DEFAULT,
fill_value: object = dtypes.NA,
Expand Down Expand Up @@ -839,18 +839,6 @@ def level(kv):
join=join,
combine_attrs=combine_attrs,
)
# Remove inherited coordinates/indexes/dimensions.
for var_name in list(merge_result.coord_names):
if not any(var_name in node._coord_variables for node in nodes):
del merge_result.variables[var_name]
merge_result.coord_names.remove(var_name)
for index_name in list(merge_result.indexes):
if not any(index_name in node._node_indexes for node in nodes):
del merge_result.indexes[index_name]
for dim in list(merge_result.dims):
if not any(dim in node._node_dims for node in nodes):
del merge_result.dims[dim]

merged_ds = Dataset._construct_direct(**merge_result._asdict())
result[key] = DataTree(dataset=merged_ds)

Expand Down
Loading