Populate field_name in InternalValidator
#1834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1834 will improve performances by 13.2%Comparing Summary
Benchmarks breakdown
|
davidhewitt
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
LGTM.
I think in the longer term I want something like #1786 to aggressively simplify/optimize InternalValidator and just have the &mut ValidationState be carried inside it, but that needs some experimentation in PyO3.
This will do for now.
|
Yeah all the clones happening here aren't ideal. |
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
…1834) Original-commit-link: pydantic/pydantic-core@0425954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes pydantic/pydantic#12357.
Related issue number
Checklist
pydantic-core(except for expected changes)