Skip to content

Fixes for Storing the Conserved Quantities before and after the poloidal Step with Arakawa method #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dominikbell wants to merge 2 commits into
base: cemracs
Choose a base branch
from
Open

Fixes for Storing the Conserved Quantities before and after the poloidal Step with Arakawa method #43

dominikbell wants to merge 2 commits into from

Conversation

@dominikbell
Copy link
Collaborator

@dominikbell dominikbell commented Nov 22, 2022

  • Fix the creation and writing to the akw_conservation.txt file
  • Rename get_total_energy to get_potential_energy

FrederikSchnack
FrederikSchnack reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@FrederikSchnack FrederikSchnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, once everything runs properly, we should probably change the structure of diagnostics in the advection step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrederikSchnack FrederikSchnack FrederikSchnack left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dominikbell @FrederikSchnack