Skip to content

Conversation

@yguclu
Copy link
Member

@yguclu yguclu commented Dec 2, 2025

@codacy-production
Copy link

codacy-production bot commented Dec 2, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% 35.71%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bb76bb1) 32022 19893 62.12%
Head commit (e3d861b) 64060 (+32038) 39790 (+19897) 62.11% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#546) 14 5 35.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@yguclu yguclu added the Next Release Must be in next release label Dec 4, 2025
@yguclu yguclu marked this pull request as ready for review December 9, 2025 16:59
@yguclu yguclu requested a review from a team December 9, 2025 17:00
@yguclu yguclu added bug Something isn't working urgent PR should be merged ASAP labels Dec 9, 2025
@campospinto
Copy link
Collaborator

campospinto commented Dec 10, 2025

Another (related?) issue is #552 [Edit: should be fixed with this PR]

@yguclu
Copy link
Member Author

yguclu commented Dec 12, 2025

@campospinto Thanks for fixing #552! Your one-liner change looks good to me.

As soon as you approve this PR, I think we can merge it

@campospinto
Copy link
Collaborator

I added the warning in the function `Geometry.from_topological_domain' to fix issue #551. If the tests pass I will approve the PR

Copy link
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me now !

@campospinto campospinto merged commit 96b4312 into devel Dec 18, 2025
10 checks passed
@campospinto campospinto deleted the fix-multipatch-bugs branch December 18, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Next Release Must be in next release urgent PR should be merged ASAP

Projects

None yet

3 participants