-
Notifications
You must be signed in to change notification settings - Fork 21
Fix some bugs in multi-patch domains #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
|
Another (related?) issue is #552 [Edit: should be fixed with this PR] |
|
@campospinto Thanks for fixing #552! Your one-liner change looks good to me. As soon as you approve this PR, I think we can merge it |
|
I added the warning in the function `Geometry.from_topological_domain' to fix issue #551. If the tests pass I will approve the PR |
campospinto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me now !
sum_factorizationargument from auxiliary equation for L2 boundary projectionDiscreteBilinearForminpsydac.api.fem_bilinear_formwork on 3D multi-patch domains #545)