-
Notifications
You must be signed in to change notification settings - Fork 21
Add Logo #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we vote on the kind of banner first, lets say until tomorrow evening, then I can provide a few different (proposed) fonts and we conclude the survey in the meeting this week? |
|
As much as I like the logo, I'm worried this could be a cause for copyright infringement: https://pokemon.gamespress.com/Media-Usage-Guidelines I'm no legal expert, but perhaps somebody with legal expertise can be consulted? Or perhaps a poorer FE approximation could generate a safer logo (honestly I don't know 😅)? If it weren't for copyright doubts the logo already works |
@yguclu I took the liberty to work on the cube font, what do you think? We can change the colors very easily. |
I think it's great! |
I also think that's great! I was going to upload my SVG file, but I think yours looks better! As for the colors, how does that look if you swap yellow and blue? |
(Edit: With only one blue tone in the text it looks even better imo) |
I think that's what we said, but if people look for logos to put in their presentations, they probably take the first one they can find, which is the repo banner. |
|
I agree that the cube font is hard to read, especially on a white background. I now added:
They can be found here: https://github.com/pyccel/psydac/tree/logo/docs/source/logo. |
Great! |
Maybe because I always use the dark theme on GitHub, I have not considered the cube logo to have any visibility issues.. A yellow banner over a white background is probably not ideal 😅 |
campospinto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Frederik! I think this logo and the associated banner look very nice.
And by "this logo" you mean which version? 😜 I have gotten lost a bit |
the one that is on the readme (in the current version of this branch). If I'm not mistaken it corresponds to #540 (comment) |
1 similar comment
the one that is on the readme (in the current version of this branch). If I'm not mistaken it corresponds to #540 (comment) |
yguclu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR!
I will have a look at the generated docs and get back to you ASAP
|
I suppose the banner will show up in the docs once we have merged the PR? |
Yes exactly, but you can check the artifacts from two commits ago. I had to put the absolute path of the banner file in the README as otherwise it will not show up in the documentation. And in order for it to work after the merge, I had to put the path it will have on the devel branch. |
yguclu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Add logo for README and documentation. Fixes #534. - Add `docs/logo/` folder with three SVG images: * `psydac_platypus.svg` with the PSYDAC platypus logo * `psydac_banner.svg` with a long banner (text + logo) for the README * `psydac_square.svg` with a compact square banner (text + logo) for use in presentations with a white background - Include contents of `README.md` in generated documentation - Use absolute paths in `README.md` for correct linking - Add `myst-parser` to documentation requirements - Fix instructions in "Building the Docs" section - Remove useless links from bottom of main page in documentation (already present on the top) - Add square PSYDAC logo to header in documentation page - Improve layout of documentation page












Hi Team! In this PR we want to fix #534.
todos:
logobranch is broken.Q:
In the following I will present the four possible logos that are available. Please react with a ❤️ emoji for the one you like the most. If there is any concrete feedback, please let me know.
Commit Summary
Add logo for README and documentation. Fixes #534.
docs/logo/folder with three SVG images:psydac_platypus.svgwith the PSYDAC platypus logopsydac_banner.svgwith a long banner (text + logo) for the READMEpsydac_square.svgwith a compact square banner (text + logo) for use in presentations with a white backgroundREADME.mdin generated documentationREADME.mdfor correct linkingmyst-parserto documentation requirements