Skip to content

Conversation

@FrederikSchnack
Copy link
Contributor

@FrederikSchnack FrederikSchnack commented Nov 14, 2025

Hi Team! In this PR we want to fix #534.

todos:

  • survey which logo to use
  • absolute path in the readme for the logo, such that it shows up in the documentation. This is done, so the preview on the logo branch is broken.

Q:

  • codacy doesn't like adding a new requirement

In the following I will present the four possible logos that are available. Please react with a ❤️ emoji for the one you like the most. If there is any concrete feedback, please let me know.

Commit Summary

Add logo for README and documentation. Fixes #534.

  • Add docs/logo/ folder with three SVG images:
    • psydac_platypus.svg with the PSYDAC platypus logo
    • psydac_banner.svg with a long banner (text + logo) for the README
    • psydac_square.svg with a compact square banner (text + logo) for use in presentations with a white background
  • Include contents of README.md in generated documentation
  • Use absolute paths in README.md for correct linking
  • Add myst-parser to documentation requirements
  • Fix instructions in "Building the Docs" section
  • Remove useless links from bottom of main page in documentation (already present on the top)
  • Add square PSYDAC logo to header in documentation page
  • Improve layout of documentation page

@FrederikSchnack
Copy link
Contributor Author

psydac_banner_alt

@FrederikSchnack
Copy link
Contributor Author

psydac_banner

@FrederikSchnack
Copy link
Contributor Author

psydac_banner_mirrored_alt

@FrederikSchnack
Copy link
Contributor Author

psydac_banner_mirrored

@FrederikSchnack FrederikSchnack requested a review from a team November 14, 2025 14:57
@campospinto
Copy link
Collaborator

campospinto commented Nov 14, 2025

psydac_banner

I prefer this logo but I'm not convinced by the text font... I think I would prefer smoother fonts, like this one or that one ... Yaman also had another idea for the text

@FrederikSchnack
Copy link
Contributor Author

FrederikSchnack commented Nov 17, 2025

psydac_banner

I prefer this logo but I'm not convinced by the text font... I think I would prefer smoother fonts, like this one or that one ... Yaman also had another idea for the text

Should we vote on the kind of banner first, lets say until tomorrow evening, then I can provide a few different (proposed) fonts and we conclude the survey in the meeting this week?

@kvrigor
Copy link
Member

kvrigor commented Nov 18, 2025

As much as I like the logo, I'm worried this could be a cause for copyright infringement: https://pokemon.gamespress.com/Media-Usage-Guidelines

I'm no legal expert, but perhaps somebody with legal expertise can be consulted?

Or perhaps a poorer FE approximation could generate a safer logo (honestly I don't know 😅)? If it weren't for copyright doubts the logo already works

@FrederikSchnack
Copy link
Contributor Author

Hear me out, what do you think of a (duck-billed) platypus?
I feel like it has the same spirit, the duck wordplay is apparent and its more exciting than an ordinary duck :D

psydac_banner_platypus

This is a quick version, that can be refined if liked...

@EmilyBourne
Copy link
Member

Hear me out, what do you think of a (duck-billed) platypus?
I feel like it has the same spirit, the duck wordplay is apparent and its more exciting than an ordinary duck :D

psydac_banner_platypus

This is a quick version, that can be refined if liked...

Good idea! I think you need to move the arms though. It looks like he's got long dog ears

@FrederikSchnack
Copy link
Contributor Author

Hear me out, what do you think of a (duck-billed) platypus?
I feel like it has the same spirit, the duck wordplay is apparent and its more exciting than an ordinary duck :D
psydac_banner_platypus
This is a quick version, that can be refined if liked...

Good idea! I think you need to move the arms though. It looks like he's got long dog ears

oh noo, now I can't unsee it 🙈

@FrederikSchnack
Copy link
Contributor Author

psydac_banner_platypus

I just added a first platypus version. Let me know what you think with the colors, limbs etc.

@yguclu yguclu added the Next Release Must be in next release label Nov 24, 2025
@FrederikSchnack
Copy link
Contributor Author

FrederikSchnack commented Nov 27, 2025

psydac_banner_platypus_cubes

@yguclu I took the liberty to work on the cube font, what do you think? We can change the colors very easily.

@jowezarek
Copy link
Contributor

psydac_banner_platypus_cubes

@yguclu I took the liberty to work on the cube font, what do you think? We can change the colors very easily.

I think it's great!

@yguclu
Copy link
Member

yguclu commented Nov 27, 2025

psydac_banner_platypus_cubes @yguclu I took the liberty to work on the cube font, what do you think? We can change the colors very easily.

I think it's great!

I also think that's great! I was going to upload my SVG file, but I think yours looks better! As for the colors, how does that look if you swap yellow and blue?

@FrederikSchnack
Copy link
Contributor Author

FrederikSchnack commented Nov 27, 2025

psydac_banner_platypus_cubes @yguclu I took the liberty to work on the cube font, what do you think? We can change the colors very easily.

I think it's great!

I also think that's great! I was going to upload my SVG file, but I think yours looks better! As for the colors, how does that look if you swap yellow and blue?

psydac_banner_platypus_cubes_yel

(Edit: With only one blue tone in the text it looks even better imo)

@FrederikSchnack
Copy link
Contributor Author

@max-models If I have not misunderstood the discussion at our weekly meeting, the logo would consist of just the duck/platypus. The word "PSYDAC" is for the banner on top of the README

I think that's what we said, but if people look for logos to put in their presentations, they probably take the first one they can find, which is the repo banner.

@FrederikSchnack
Copy link
Contributor Author

I agree that the cube font is hard to read, especially on a white background. I now added:

  • a psydac platypus banner with cube font
  • a psydac platypus alternative banner with the font Martin proposed
  • a psydac platypus square logo
  • the psydac platypus

They can be found here: https://github.com/pyccel/psydac/tree/logo/docs/source/logo.

@FrederikSchnack
Copy link
Contributor Author

This is what the documentation looks like with the current setup:
image

@max-models
Copy link
Contributor

I agree that the cube font is hard to read, especially on a white background. I now added:

  • a psydac platypus banner with cube font
  • a psydac platypus alternative banner with the font Martin proposed
  • a psydac platypus square logo
  • the psydac platypus

They can be found here: https://github.com/pyccel/psydac/tree/logo/docs/source/logo.

Great!

@yguclu
Copy link
Member

yguclu commented Nov 28, 2025

I agree that the cube font is hard to read, especially on a white background. I now added:

  • a psydac platypus banner with cube font

  • a psydac platypus alternative banner with the font Martin proposed

  • a psydac platypus square logo

  • the psydac platypus

They can be found here: https://github.com/pyccel/psydac/tree/logo/docs/source/logo.

Maybe because I always use the dark theme on GitHub, I have not considered the cube logo to have any visibility issues.. A yellow banner over a white background is probably not ideal 😅

Copy link
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Frederik! I think this logo and the associated banner look very nice.

@yguclu
Copy link
Member

yguclu commented Nov 28, 2025

Thanks Frederik! I think this logo and the associated banner look very nice.

And by "this logo" you mean which version? 😜 I have gotten lost a bit

@campospinto
Copy link
Collaborator

Thanks Frederik! I think this logo and the associated banner look very nice.

And by "this logo" you mean which version? 😜 I have gotten lost a bit

the one that is on the readme (in the current version of this branch). If I'm not mistaken it corresponds to #540 (comment)

1 similar comment
@campospinto
Copy link
Collaborator

Thanks Frederik! I think this logo and the associated banner look very nice.

And by "this logo" you mean which version? 😜 I have gotten lost a bit

the one that is on the readme (in the current version of this branch). If I'm not mistaken it corresponds to #540 (comment)

Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR!

I will have a look at the generated docs and get back to you ASAP

@yguclu
Copy link
Member

yguclu commented Nov 28, 2025

I suppose the banner will show up in the docs once we have merged the PR?

@FrederikSchnack
Copy link
Contributor Author

I suppose the banner will show up in the docs once we have merged the PR?

Yes exactly, but you can check the artifacts from two commits ago. I had to put the absolute path of the banner file in the README as otherwise it will not show up in the documentation. And in order for it to work after the merge, I had to put the path it will have on the devel branch.

Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yguclu yguclu enabled auto-merge (squash) November 28, 2025 19:00
@codacy-production
Copy link

codacy-production bot commented Nov 28, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b68b7eb) 31852 19688 61.81%
Head commit (3897bc0) 63704 (+31852) 39374 (+19686) 61.81% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#540) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@yguclu yguclu merged commit a89a6ee into devel Nov 28, 2025
9 checks passed
@yguclu yguclu deleted the logo branch November 28, 2025 19:54
campospinto pushed a commit that referenced this pull request Dec 12, 2025
Add logo for README and documentation. Fixes #534.

- Add `docs/logo/` folder with three SVG images:
   * `psydac_platypus.svg` with the PSYDAC platypus logo
   * `psydac_banner.svg` with a long banner (text + logo) for the README
* `psydac_square.svg` with a compact square banner (text + logo) for use
in presentations with a white background
- Include contents of `README.md` in generated documentation
- Use absolute paths in `README.md` for correct linking
- Add `myst-parser` to documentation requirements
- Fix instructions in "Building the Docs" section
- Remove useless links from bottom of main page in documentation
(already present on the top)
- Add square PSYDAC logo to header in documentation page
- Improve layout of documentation page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Next Release Must be in next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create logo for library

8 participants