fix: misc fixes with histogram behaviors and styles for both backends#264
Merged
tlambert03 merged 14 commits intopyapp-kit:mainfrom Mar 28, 2026
Merged
fix: misc fixes with histogram behaviors and styles for both backends#264tlambert03 merged 14 commits intopyapp-kit:mainfrom
tlambert03 merged 14 commits intopyapp-kit:mainfrom
Conversation
…LogTicker for better tick management
…yGFXHistogramCanvas
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 86.79% 85.84% -0.96%
==========================================
Files 50 50
Lines 5725 5848 +123
==========================================
+ Hits 4969 5020 +51
- Misses 756 828 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vispy Histogram
IndexErrorinPanZoom1DCamera.pan()(when click-dragging on vispy histogram... cc @fdrgsp )LogTickerthat shows original count values (0, 1, 10, 100, 1000) at log-spaced positions instead of hiding labels entirelyset_datanow passes the new max count to_resize, so the y-range updates with each data changePyGFX Histogram
margin_leftreduced from 50 to 34_resize_resizeonly applies log transform to raw count values, not to already-transformedscale_yfallback_animateon canvas resize, so labels appear immediatelytick_format=".0f"on y-axis ruler_update_y_rulerhelper — deduplicates y-axis ruler logic between_resizeand_animateOther
show_roi_buttondefault changed toFalse