feat: pure_12hr_system_time option for 12 hour system time#412
Open
ThatOneCalculator wants to merge 2 commits intopure-fish:masterfrom
Open
feat: pure_12hr_system_time option for 12 hour system time#412ThatOneCalculator wants to merge 2 commits intopure-fish:masterfrom
pure_12hr_system_time option for 12 hour system time#412ThatOneCalculator wants to merge 2 commits intopure-fish:masterfrom
Conversation
edouard-lopez
requested changes
Mar 16, 2026
Member
edouard-lopez
left a comment
There was a problem hiding this comment.
Thanks for the PR!
issue: the implementation is far too specific, and we don't want to re-implement every date-supported format.
suggestion: A simpler solution would be to
-
set the format in a universal variable (cf.
conf.d/pure.fish) likepure_show_system_time_format; -
set its default to
+%T(so we preserve existing behaviour) ; -
then users can simply override this variable on their config with
set --universal pure_show_system_time_format '+%I:%M:%S %p'
todo: add a sample in the doc
Author
|
Done! Made the variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specs
12 hour system time, if system time is enabled
New config in
conf.d/pure.fish_pure_set_default pure_12hr_system_time falseDocumentation
Usage
Acceptance Checks
conf.d/pure.fishfor:tests/feature_name.test.fish;