Skip to content

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Sep 24, 2025

This PR was generated via $ upgrade-provider pulumi/pulumi-aws --repo-path ..


Closes #5852

@EronWright EronWright added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Sep 24, 2025
@EronWright EronWright requested review from Copilot and a team September 24, 2025 23:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good concerns!

The Java Gradle version is expected to be a dev version, similar to https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/package.json#L27.

There were recent changes upstream to import sections, which is exposing the flakiness of our import section processing. It's worth an issue in the bridge but I'm not sure it's worth blocking the release.

@Graham-Pedersen
Copy link

Are the tests currently bugged with that "waiting for status" thing someone was talking about the other day?

Copy link

github-actions bot commented Sep 25, 2025

Does the PR have any schema changes?

Found 3 breaking changes:

Resources

  • 🟢 "aws:rds/clusterRoleAssociation:ClusterRoleAssociation": required: "featureName" property is no longer Required

Types

  • 🟢 "aws:dynamodb/getTableGlobalSecondaryIndex:getTableGlobalSecondaryIndex": required: "warmThroughputs" property has changed to Required
  • 🟢 "aws:ec2/getLaunchTemplatePlacement:getLaunchTemplatePlacement": required: "groupId" property has changed to Required

New resources:

  • cognito/managedLoginBranding.ManagedLoginBranding
  • controltower/baseline.Baseline
  • odb/cloudAutonomousVmCluster.CloudAutonomousVmCluster
  • odb/cloudExadataInfrastructure.CloudExadataInfrastructure
  • odb/cloudVmCluster.CloudVmCluster
  • odb/network.Network
  • odb/networkPeeringConnection.NetworkPeeringConnection

New functions:

  • billing/getViews.getViews
  • odb/getCloudAutonomousVmCluster.getCloudAutonomousVmCluster
  • odb/getCloudExadataInfrastructure.getCloudExadataInfrastructure
  • odb/getCloudVmCluster.getCloudVmCluster
  • odb/getNetwork.getNetwork
  • odb/getNetworkPeeringConnection.getNetworkPeeringConnection

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.26%. Comparing base (00a3584) to head (653b4a1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5853      +/-   ##
==========================================
+ Coverage   25.12%   25.26%   +0.13%     
==========================================
  Files         363      365       +2     
  Lines      148034   150160    +2126     
==========================================
+ Hits        37197    37934     +737     
- Misses     110745   112133    +1388     
- Partials       92       93       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guineveresaenger
Copy link
Contributor

You'll want to re-generate the schema and SDKs again, because the docs changes from replacements.json need to be written to the schema.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the .sln file but other than that this looks good!

EronWright and others added 3 commits September 26, 2025 16:53
The Java SDK was out-of-date due to recent schema changes from:
- replacements.json updates (8c47a71)
- make tfgen schema regeneration (0045672)

This regenerates all SDKs to ensure they are in sync with the
latest provider version 6.14.1 changes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
This was referenced Sep 29, 2025
@EronWright EronWright disabled auto-merge September 29, 2025 22:10
@EronWright EronWright disabled auto-merge October 1, 2025 15:44
@EronWright EronWright merged commit d194a7c into master Oct 1, 2025
17 of 22 checks passed
@EronWright EronWright deleted the upgrade-terraform-provider-aws-to-v6.14.1 branch October 1, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0
Projects
None yet
3 participants