Draft a workflow to help keep PR up-to-date #4669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need to land it on master first and iterate on this a bit, since I'm not sure we can test a workflow otherwise before it is merged. |
|
Oh never mind, this is somehow running already. SO I can experiment without merging. Will do. |
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the maintainer chores on this repository is keeping schema and SDKs re-generated and up-to-date. This introduces a workflow to help with that. When working on a PR maintainer/feature, the automation will stand up and keep re-generating an auxillary PR with a branch called "maintainer/feature-gen". This auxillary PR will:
This PR will appear then the original PR is opened, and will be force-pushed to and rebuilt any time the original PR is changing by adding commits or force-pushing.
This may enable maintainers to review source-only changes and check them in quickly. The automatic changes are still worth consulting for review. Having these in two PRs has some trade-offs of making it easier on the author vs harder on the reviewer, so this workflow may be considered an experiment.