Skip to content

[PULP-1668] Optimize QueryExistingArtifacts queries #7760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dralley merged 1 commit into from
Jun 3, 2026
Merged

[PULP-1668] Optimize QueryExistingArtifacts queries #7760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/7558.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Optimized `QueryExistingArtifacts` by reducing database queries.
Comment thread
jobselko marked this conversation as resolved.
12 changes: 5 additions & 7 deletions pulpcore/plugin/stages/artifact_stages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,15 @@ async def run(self):
"pulp_domain": self.domain,
}
existing_artifacts_qs = Artifact.objects.filter(**query_params)
existing_artifacts = sync_to_async_iterable(existing_artifacts_qs)
await sync_to_async(existing_artifacts_qs.touch)()
existing_by_digest = {}
async for result in sync_to_async_iterable(existing_artifacts_qs):
existing_by_digest[getattr(result, digest_type)] = result
for d_content in batch:
for d_artifact in d_content.d_artifacts:
artifact_digest = getattr(d_artifact.artifact, digest_type)
if artifact_digest:
async for result in existing_artifacts:
result_digest = getattr(result, digest_type)
if result_digest == artifact_digest:
d_artifact.artifact = result
break
if artifact_digest and artifact_digest in existing_by_digest:
d_artifact.artifact = existing_by_digest[artifact_digest]
for d_content in batch:
await self.put(d_content)

Expand Down
Loading