Generate HASHIDS_SALT for existing installs - #5701
Open
jondycz wants to merge 2 commits into
Open
Conversation
Member
|
This looks like it would append an additional HASHIDS_SALT= line to the .env file every time the container starts, unless you declare the HASHIDS_SALT in the containers environment. |
Author
Just noticed that. Will update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply moves the code for HASHIDS_SALT outside of the else block guarded by clause checking for existence of .env - this breaks generation of HASHIDS_SALT for existing installs lacking the env variable causing error 500 on the user dashboard in "Database" tab.
Additionally checks for existence of HASHIDS_SALT in /app/var/.env in order to not inflate the file size by redefining the variable on every restart.
fixes #5700