Improve danger text readability - #5672
Open
egg400 wants to merge 1 commit into
Open
Conversation
|
I like this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to delete a server on the panel, you'll see warnings that say stuff like "Deleting a server is an irreversible action. All server data...". This is useful, however, the text is extremely hard to read due to the background. A user would need to highlight the text to make it readable.
I've tried changing the text color to other colors, but they didn't provide enough contrast either. I eventually decided to make the background of the text red and make the text white. I've tried to keep the design as close as possible to the Pterodactyl UI.
This change is only 4 lines in CSS. Check attached images for before & after.
Before
After
