Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 6 +2
Lines 346 1032 +686
==========================================
+ Hits 346 1032 +686 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
💡 Codex Review
Line 214 in 6a4913a
tidy.cpm(component = "edges") unconditionally calls apply(sum_x$edges, 2, list), but sum_x$edges is NULL for the default cpm() workflow (return_edges = "none"). In that common path this raises a hard error (dim(X) must have a positive length) instead of returning a usable result or a clear user-facing message, so users cannot tidy edge output unless they know to override edge storage up front.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0a57d41 to
c1f6dfb
Compare
a729e18 to
7cfe746
Compare
d42570c to
b1d5be1
Compare
|
/benchmark |
|
Touchstone benchmark results for
|
* feat: add cpm spec and fit skeleton * style: apply air formatting suggestions * test: cover cpm_spec print branches * docs: guide phase-two fit migration usage * docs: rebuild README from README.Rmd * Add GitHub Actions workflow for documentation generation * devtools::document() Signed-off-by: Liang Zhang <psychelzh@outlook.com> * feat!: remove cpm() wrapper and finalize fit(cpm_spec) migration - drop legacy cpm() entry-point and related docs - keep fit(cpm_spec(), ...) as sole API path - update tests, snapshots, README, and vignette for new API - apply formatting fixes required by CI BREAKING CHANGE: cpm() and confounds alias are removed. * fix: resolve devtools::document warnings blocking CI * refactor: drop local %||% and rely on base operator --------- Signed-off-by: Liang Zhang <psychelzh@outlook.com>
Merged via squash. Completes semantics split, argument boundaries, result-object documentation, and accessor verbs. Remaining items (glance, augment, predict design) tracked in #34.
b1d5be1 to
6e264ce
Compare
|
/benchmark |
|
Touchstone benchmark results for
|
Summary
API changes
Internal cleanup
Validation