Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

Update Bazel workspace dependencies to 7.6.2 compatibility with MODULE.bazel support

@mpwarres
Copy link

Thanks for the PR! LGTM, but we will need @PiotrSikora 's review and approval as the owner.

The msrv workflow is failing due to:

error: package `quote v1.0.42` cannot be built because it requires rustc 1.68 or newer, while the currently active rustc version is 1.65.0

Seems we could either revert the quote version bump in this PR, or else change the rust.yml workflow to use a more recent Rust toolchain. @PiotrSikora WDYT?

@mmorel-35
Copy link
Contributor Author

Let's rollback cargo versions modification and focus on Bazel MODULE support


load("@proxy_wasm_rust_sdk//bazel:dependencies.bzl", "proxy_wasm_rust_sdk_dependencies")

proxy_wasm_rust_sdk_dependencies()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could those be moved to proxy_wasm_rust_sdk_dependencies()? Otherwise, they won't be automatically executed in the dependent projects.

@PiotrSikora
Copy link
Member

There is also a question whether we want to support the old WORKSPACE-based model. If we do, then I think we should add it to the CI to make sure it works.

@mmorel-35 mmorel-35 force-pushed the update-deps branch 2 times, most recently from 384e752 to 78df173 Compare November 25, 2025 18:20
@mmorel-35
Copy link
Contributor Author

I believe it's better to start by updating dependencies and then provide the MODULE.bazel. I opened #334

You probably want to support MODULE and WORKSPACE for some few minor versions to allow the users of your library to migrate smoothly

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

But it's now clear that this should be 2 PRs: updating rules_cc, and adding support for MODULE.bazel (unless they are somehow intertwined, but it doesn't look like it).

Could you split them? Thank you!

@mmorel-35 mmorel-35 marked this pull request as draft November 26, 2025 17:20
@@ -1 +1 @@
7.6.1
7.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update to 7.6.2 and not the latest 7.x (i.e. 7.7.1) or even 8.x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.7.1 was published only few days ago. My long term goal is to turn envoy in bzlmod and it is yet in 7.6.2 so I just need to ensure actual compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants