fix(om2): clarify empty UNIT/HELP value wording#2931
Merged
Conversation
Be more precise about where the empty value appears (before the newline) and align with standard spec language. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Coded with Claude Sonnet 4.6.
dashpole
approved these changes
Mar 28, 2026
bwplotka
approved these changes
Mar 30, 2026
| If the unit is known it SHOULD be provided. | ||
|
|
||
| The value of a UNIT or HELP line MAY be empty. This MUST be treated as if no metadata line for the MetricFamily existed. | ||
| A UNIT or HELP metadata line MAY have an empty value string before the newline. This MUST be treated as if the metadata line were not present. |
Member
There was a problem hiding this comment.
I'd prefer if we simplify, but it's ok.
Suggested change
| A UNIT or HELP metadata line MAY have an empty value string before the newline. This MUST be treated as if the metadata line were not present. | |
| A UNIT or HELP metadata line MAY have an empty value. This MUST be treated as if the metadata line were not present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com
🤖 Coded with Claude Sonnet 4.6. Generated with Claude Code