Resurrect changes by shappir to improve memory usage of sparse histograms. - #760
Open
jdmarshall wants to merge 2 commits into
Open
Resurrect changes by shappir to improve memory usage of sparse histograms. #760jdmarshall wants to merge 2 commits into
jdmarshall wants to merge 2 commits into
Conversation
zbjornson
reviewed
Aug 9, 2026
| - AggregatorRegistry renamed to ClusterRegistry, old name deprecated | ||
| - chore: update faceoff to 1.1 | ||
| - perf: Stat aggregation uses similar strategy to collection. 60% faster aggregation | ||
| - fix: Avoid updating exemplar values during subsequent metric changes (Fixes [#616](https://github.com/prometheus/client_js/issues/616)) |
Contributor
There was a problem hiding this comment.
#616 was marked fixed in v15.1.1 and this line is already in the changelog.
| - chore: Add copyright license headers and test | ||
| - Make cluster and worker-thread metric aggregation order deterministic | ||
| - Export `MetricObject`, `MetricObjectWithValues`, `MetricValue` and `MetricValueWithName` from the TypeScript definitions | ||
| - perf: Improvet the memory usage of histograms by delaying allocation of bucket data |
Contributor
There was a problem hiding this comment.
Suggested change
| - perf: Improvet the memory usage of histograms by delaying allocation of bucket data | |
| - perf: Improve the memory usage of histograms by delaying allocation of bucket data |
Contributor
Author
There was a problem hiding this comment.
Github merge let me down. Not sure what happened here. Forcing back to previous
Contributor
There was a problem hiding this comment.
Not sure if you always use the "create merge commit" merge method, but the second commit is basically empty/has the wrong commit message and could be rebased out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resurrects a PR from 2 years ago written by @shappir to work on top of the storage engine changes that are landing in 0.16
This also includes a bug fix for #616
This looks to be a few % faster than what is currently on trunk. I'm unclear on how much this improves memory efficiency, but this should be fine.