Allow connect on Http2ProtocolOptions when Websockets are enabled #6846

rajatvig · 2025-01-12T00:59:47Z

This should possibly address part of #3371 and possibly knative/serving#13083 when using Knative with Contour.

Signed-off-by: Rajat Vig [email protected]

codecov · 2025-01-12T01:24:41Z

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.67%. Comparing base (0c79cd1) to head (a18770b).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/envoy/v3/listener.go	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6846      +/-   ##
==========================================
- Coverage   81.85%   81.67%   -0.18%     
==========================================
  Files         130      130              
  Lines       15747    15750       +3     
==========================================
- Hits        12889    12864      -25     
  Misses       2574     2574              
- Partials      284      312      +28

Files with missing lines	Coverage Δ
internal/envoy/v3/listener.go	`93.07% <80.00%> (-5.10%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-01-27T00:26:23Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2025-02-14T00:25:59Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2025-03-01T00:29:18Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2025-03-31T00:30:04Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2025-04-16T00:29:09Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

sunjayBhatia

Looks like we need some more unit testing to validate this config update logic

sunjayBhatia · 2025-04-29T21:10:53Z

internal/envoy/v3/listener.go

+	}
+
+	// Assign http2Options only if it has been modified
+	if b.http2MaxConcurrentStreams != nil {


i dont think this is quite right? if max concurrent streams is not set, but websockets are enabled we would still want to set the http2 options

github-actions · 2025-05-30T00:30:06Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

John-Lin · 2025-06-09T09:43:45Z

any progress on this PR? thanks

rajatvig · 2025-06-09T11:22:58Z

Will update this week. Missed changing it for the given feedback.

github-actions · 2025-07-10T00:31:17Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

John-Lin · 2025-08-12T06:18:05Z

Hi, @rajatvig just checking in to see how the PR is progressing.

github-actions · 2025-09-13T00:25:39Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

Signed-off-by: Rajat Vig <[email protected]>

rajatvig · 2025-11-07T19:52:23Z

@John-Lin @sunjayBhatia Sorry for the delay here. Rebased the branch and addressed feedback and also added unit tests for it.

rajatvig · 2025-11-07T20:12:10Z

Am unsure on why the coverage fell after adding in unit tests. Local run shows me coverage is better

Signed-off-by: Rajat Vig <[email protected]>

github-actions · 2025-12-11T00:32:21Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

rajatvig force-pushed the AllowConnect branch from 45da937 to 98bfa41 Compare January 12, 2025 01:01

rajatvig added the release-note/small A small change that needs one line of explanation in the release notes. label Jan 12, 2025

rajatvig marked this pull request as ready for review January 12, 2025 01:25

rajatvig requested a review from a team as a code owner January 12, 2025 01:25

rajatvig requested review from sunjayBhatia and tsaarni and removed request for a team January 12, 2025 01:25

sunjayBhatia requested review from a team, clayton-gonsalves and davinci26 and removed request for a team January 12, 2025 01:26

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2025

sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2025

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2025

rajatvig removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2025

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 1, 2025

github-actions bot closed this Mar 31, 2025

tsaarni reopened this Mar 31, 2025

sunjayBhatia requested a review from a team March 31, 2025 03:44

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 1, 2025

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2025

sunjayBhatia requested changes Apr 29, 2025

View reviewed changes

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2025

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 30, 2025

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 10, 2025

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2025

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2025

rajatvig added 3 commits November 7, 2025 19:37

Allow connect on Http2ProtocolOptions when Websockets are enabled

ddaee09

Signed-off-by: Rajat Vig <[email protected]>

Fix release note

70d0e5e

Signed-off-by: Rajat Vig <[email protected]>

Fix code logic

f343167

Signed-off-by: Rajat Vig <[email protected]>

rajatvig force-pushed the AllowConnect branch from 0da4d80 to 940ecd6 Compare November 7, 2025 19:49

Address feedback and add unit tests

fc9ef7d

Signed-off-by: Rajat Vig <[email protected]>

rajatvig force-pushed the AllowConnect branch from 940ecd6 to fc9ef7d Compare November 7, 2025 19:50

fix comment

a18770b

Signed-off-by: Rajat Vig <[email protected]>

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2025

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 11, 2025

Allow connect on Http2ProtocolOptions when Websockets are enabled #6846

Are you sure you want to change the base?

Allow connect on Http2ProtocolOptions when Websockets are enabled #6846

Conversation

rajatvig commented Jan 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 27, 2025

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

sunjayBhatia left a comment

Choose a reason for hiding this comment

Uh oh!

sunjayBhatia Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

John-Lin commented Jun 9, 2025

Uh oh!

rajatvig commented Jun 9, 2025

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

John-Lin commented Aug 12, 2025

Uh oh!

github-actions bot commented Sep 13, 2025

Uh oh!

rajatvig commented Nov 7, 2025

Uh oh!

rajatvig commented Nov 7, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rajatvig commented Jan 12, 2025 •

edited

Loading

codecov bot commented Jan 12, 2025 •

edited

Loading