Fix e2e validation: update results.json.reference for Status and ReleaseStream fields - #40
Merged
Merged
Conversation
Commit 101b2d6 added Status to Result and ReleaseStream to ClusterDetails but didn't update the reference file used by the e2e validation step, causing CI to fail on every run since. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the e2e CI failure introduced in #37. That PR added two new fields to the output but didn't update
results.json.reference:Status(string) onResult— set to"success"on passing tests, noomitemptyeffectReleaseStream(string) onClusterDetails— always serialised, even when emptyThe
validate_results.gostructural comparison fails when the key count between reference and generated output differs, so CI has been broken since #37 merged.🤖 Generated with Claude Code