This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Atomic/scan.py: Fix scan error message (BZ #1508453) #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
change LGTM, tests aren't happy though. |
|
@baude Can we also put the actual path to the correct configuration file into that error message? |
|
bot, retest this please |
|
@matusmarhefka that would be a bit harder ... but if you feel strongly, i could attempt to do that. |
|
@baude I leave it up to you. But if it would require too many code changes, we can go with the current fix. |
|
is this preferred? |
|
@baude Yes, that looks good. |
baude
force-pushed
the
scan_error
branch
2 times, most recently
from
f8c7399 to
c4b1faa
Compare
|
bot, retest this please |
BZ #1508453 correctly points out that the error message points to the wrong file when telling the user it cannot find the scanner image or arguments. Signed-off-by: baude <[email protected]>
|
bot, retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BZ #1508453 correctly points out that the error message
points to the wrong file when telling the user it cannot
find the scanner image or arguments.
Signed-off-by: baude [email protected]
Related Bugzillas
Related Issue Numbers
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.