Skip to content

Conversation

@sutaakar
Copy link
Contributor

Issue link

What changes have been made

Upgrade CodeFlare operator to Go lang 1.22.4 and remove AppWrapper workaround for downgrading Go lang version.

Verification steps

PR check succeeds.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar requested review from dgrove-oss and removed request for KPostOffice and tedhtchang November 20, 2024 14:19
Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- nice to be able to simplify this

@sutaakar
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrove-oss, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dd6851a into project-codeflare:main Nov 20, 2024
8 checks passed
@sutaakar sutaakar deleted the appwrapper branch November 20, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants