- 
                Notifications
    You must be signed in to change notification settings 
- Fork 66
Raise Kueue version in CodeFlare operator #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise Kueue version in CodeFlare operator #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest pulling the change in ray version out of this PR. My guess is that is the source of the problem.
| github.com/project-codeflare/appwrapper v0.27.0 | ||
| github.com/project-codeflare/codeflare-common v0.0.0-20240930133152-11fd6e3be6b3 | ||
| github.com/ray-project/kuberay/ray-operator v1.1.1 | ||
| github.com/ray-project/kuberay/ray-operator v1.2.1 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is brought by Kueue 0.8.3 dependency. That is why I had to rewrite it below.
a39eea3    to
    97a2239      
    Compare
  
    7437b9b    to
    0a48f8b      
    Compare
  
    0a48f8b    to
    a70384c      
    Compare
  
    | @dgrove-oss Please take a look. | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
2973dec
      into
      
  
    project-codeflare:main
  
    
Issue link
N/A
What changes have been made
Raise Kueue version in CodeFlare operator to use latest Kueue dependency available in ODH.
Verification steps
E2E tests pass.
Checks