pr05 Typescript Migration #15: Redux base files & migrate user preferences redux system #3683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formParams, getState, and setter params
clairep94
commented
Oct 11, 2025
Comment on lines
+9
to
+12
| export interface PreferencesState | ||
| extends Omit<Preferences, 'indentationAmount' | 'isTabIndent'> { | ||
| tabIndex: number; | ||
| } |
There was a problem hiding this comment.
There's a slight misalignment between the server & client here
It also seems like not all properties from either definition are exposed on the frontend currently:
clairep94
commented
Oct 11, 2025
Comment on lines
+20
to
+21
| if (!stored) return null; // handle null before parsing | ||
| return JSON.parse(stored) as RootState; |
There was a problem hiding this comment.
to handle type-error from getItem potentially returnning undefined
clairep94
commented
Oct 11, 2025
There was a problem hiding this comment.
deleted as this file isn't called anywhere else
additionally the below lines are called in client/index.jsx here
clairep94
changed the title
khanniie
previously approved these changes
Oct 12, 2025
4 tasks
clairep94
dismissed
khanniie’s stale review
The merge-base changed after approval.
raclim
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be reviewed after #3681
Migration of the
preferences(user preferences) redux reducer & migration of base redux reducer filesUserPreferencestype to define thePreferencesStatePreferencesState['somefield']to get the type forsomefield(which is defined byUserPreferences['somefield']UserPreferencesas the source of truth, and creates a link that can be traced from client to server.Changes:
clientdefined inservertocommonclient/custom.d.tsWindowtype to have redux devtoolsNodeModulestype to have hot reloadingclient/persistStateclient/reducers-- defineRootReducerclient/storeclient/storeInstance:client/index.jsxhere so it seems it may be outdatedclient/modules/IDE/reducers/preferences:UserPreferencestype defined in server as basis forPreferencesStateclient/modules/IDE/actions/preferences:UpdatePreferencesRequestBodyfromcommontypesactionsandvaluesin co-located filepreferences.typesPreferenceStatepropertiesI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123