Skip to content

fix(Media): normalize mimeType for audio/wav #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barryvdh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(Media): normalize mimeType for audio/wav #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2fcdf4
Normalize mimeType for audio.wav
barryvdh Apr 2, 2026
b819dc6
Fix mime type from 'audio/x-wav' to 'audio/wav'
barryvdh Apr 2, 2026
dc20d12
Refactor mimeType matching to remove strtolower
barryvdh Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/ValueObjects/Media/Media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,15 @@ public function base64(): ?string

public function mimeType(): ?string
{
if ($this->mimeType) {
return $this->mimeType;
}

if ($content = $this->rawContent()) {
if ($this->mimeType === null && $content = $this->rawContent()) {
$this->mimeType = (new finfo(FILEINFO_MIME_TYPE))->buffer($content) ?: null;
}

$this->mimeType = match ($this->mimeType) {
'audio/x-wav', 'audio/wave', 'audio/x-pn-wav', 'audio/vnd.wave' => 'audio/wav',
default => $this->mimeType,
};

return $this->mimeType;
}

Expand Down
6 changes: 3 additions & 3 deletions tests/Providers/Gemini/GeminiMediaTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ function (Request $request): bool {
'text' => 'Transcribe this audio',
])
->and($message[1]['inline_data'])->toHaveKeys(['mime_type', 'data'])
->and($message[1]['inline_data']['mime_type'])->toBe('audio/x-wav')
->and($message[1]['inline_data']['mime_type'])->toBe('audio/wav')
->and($message[1]['inline_data']['data'])->toBe(
base64_encode(file_get_contents('tests/Fixtures/sample-audio.wav'))
);
Expand All @@ -171,7 +171,7 @@ function (Request $request): bool {
$audioUrl => Http::response(
file_get_contents('tests/Fixtures/sample-audio.wav'),
200,
['Content-Type' => 'audio/x-wav']
['Content-Type' => 'audio/wav']
),
]);

Expand All @@ -197,7 +197,7 @@ function (Request $request): bool {
'text' => 'What is in this audio',
])
->and($message[1]['inline_data'])->toHaveKeys(['mime_type', 'data'])
->and($message[1]['inline_data']['mime_type'])->toBe('audio/x-wav')
->and($message[1]['inline_data']['mime_type'])->toBe('audio/wav')
->and($message[1]['inline_data']['data'])->toBe(
base64_encode(file_get_contents('tests/Fixtures/sample-audio.wav'))
);
Expand Down
Loading