Skip to content

Add document_count support in Collection #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tristandeborde wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add document_count support in Collection #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f5e9b3
Add document_count call in collection class
Jan 30, 2020
0ec6e40
Add estimated_document_count method in collection class
tristandeborde Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mongokat/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ def exists(self, query, **args):
def count(self, *args, **kwargs):
return self._collection_with_options(kwargs).count(*args, **kwargs)

def count_documents(self, *args, **kwargs):
return self._collection_with_options(kwargs).count_documents(*args, **kwargs)

def estimated_document_count(self, **kwargs):
return self._collection_with_options(kwargs).estimated_document_count(**kwargs)

def distinct(self, *args, **kwargs):
return self._collection_with_options(kwargs).distinct(*args, **kwargs)

Expand Down
17 changes: 17 additions & 0 deletions tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,16 @@ def test_document_common_methods(Sample):
import collections

assert Sample.collection.find().count() == 0
assert Sample.collection.find().count_documents({}) == 0
assert Sample.collection.find().estimated_document_count() == 0

# Instanciate
new_object = Sample({"name": "XXX", "url": "http://example.com"})

# Should not save to DB yet.
assert Sample.collection.find().count() == 0
assert Sample.collection.find().count_documents({}) == 0
assert Sample.collection.find().estimated_document_count() == 0

# Now save()
new_object.save()
Expand All @@ -106,6 +110,8 @@ def test_document_common_methods(Sample):
assert type(new_object["_id"]) == ObjectId

assert Sample.collection.find().count() == 1
assert Sample.collection.find().count_documents({}) == 1
assert Sample.collection.find().estimated_document_count() == 1
db_object = Sample.collection.find_one()
assert type(db_object) == dict
assert db_object["name"] == "XXX"
Expand All @@ -115,6 +121,8 @@ def test_document_common_methods(Sample):
assert type(inserted_object) == ObjectId

assert Sample.collection.find().count() == 2
assert Sample.collection.find().count_documents({}) == 2
assert Sample.collection.find().estimated_document_count() == 2

# Find back with different methods
orm_object = Sample.find_by_id(db_object["_id"])
Expand Down Expand Up @@ -168,11 +176,15 @@ def test_document_common_methods(Sample):
orm_object.save()

assert Sample.collection.find().count() == 2
assert Sample.collection.find().count_documents({}) == 2
assert Sample.collection.find().estimated_document_count() == 2

# FIXME not anymore as we are requesting _id for each query
# orm_object.save(force=True)

# assert Sample.collection.find().count() == 3
# assert Sample.collection.find().count_documents({}) == 3
# assert Sample.collection.find().estimated_document_count() == 3

orm_object = Sample.find_by_id(db_object["_id"], fields=["url", "_id"])
assert dict(orm_object) == {"url": "http://example.com", "_id": db_object["_id"]}
Expand All @@ -186,13 +198,18 @@ def test_document_common_methods(Sample):
orm_object.save()

assert Sample.collection.find().count() == 2
assert Sample.collection.find().count_documents({}) == 2
assert Sample.collection.find().estimated_document_count() == 2

db_object = Sample.collection.find_one({"_id": db_object["_id"]})
assert "name" in db_object

orm_object.save(force=True)

# Should not add anything new
assert Sample.collection.find().count() == 2
assert Sample.collection.find().count_documents({}) == 2
assert Sample.collection.find().estimated_document_count() == 2

db_object = Sample.collection.find_one({"_id": db_object["_id"]})
assert "name" not in db_object
Expand Down