This repository was archived by the owner on Dec 16, 2022. It is now read-only.
No Wram Execution Command Line Argument#101
Open
anmart wants to merge 4 commits intopret:masterfrom
anmart:master
Open
No Wram Execution Command Line Argument#101anmart wants to merge 4 commits intopret:masterfrom anmart:master
anmart wants to merge 4 commits intopret:masterfrom
anmart:master
Conversation
operation that involve execution such as jp and call
Member
|
To be fair, tcgdisasm.py is a shitty edit of gbz80disasm.py that allows it to handle the farcall macro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a suggestion with code to back it up than a commit. I tried using tcgdisasm.py and got a couple jumps to wram labels that I didn't want. Rather than fixing them manually, I thought it would be nice to have an argument that could force the disassembler to skip wram labels when considering calls or jumps.
I know very little about python and even less about the poketools, but I thought I'd give writing the modifications a shot. I'd just like for wram execution avoidance to be an option eventually.
edit: I realized this wasn't as clear as it could have been. In tcgdisasm.py (and I believe only this script), pointers in bank 3 were being replaced with wram labels because the disassembler assumed that they were addresses in bank 3. -nwe just enables the script to assume labels starting with "w" are not local labels.