refactor(ui): consolidate navbar icons into settings dropdown#2015
Open
kasiazjc wants to merge 5 commits into
Open
refactor(ui): consolidate navbar icons into settings dropdown#2015kasiazjc wants to merge 5 commits into
kasiazjc wants to merge 5 commits into
Conversation
… comments icon Group Live Events, Knowledge, Documentation, Theme, and Settings into a single gear-icon dropdown. Theme entry opens a cascading submenu reusing ThemeContext logic. Remove standalone comments icon (reachable via the BoardTeammatePanel sidebar). User avatar dropdown untouched. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… items Review found the settings-dropdown consolidation lost modifier-click (cmd/ctrl/middle-click open-in-new-tab) behavior on Knowledge and Documentation by swapping real anchors for onClick handlers. Render them as anchors inside the menu item label again, reusing the original modifier-key-aware handler for Knowledge. Also tighten themeMode from string to the real ThemeMode union, and add coverage for the theme submenu, event stream, settings, and modified-click paths. Co-Authored-By: Claude <noreply@anthropic.com>
MarketingScreenshotPage and MarketingVideoPage still passed currentBoardName/currentBoardIcon/unreadCommentsCount/hasUserMentions, which AppHeaderProps no longer declares after the settings-dropdown consolidation. CI's monorepo typecheck caught it; the narrow AppHeader test files run locally did not. Co-Authored-By: Claude <noreply@anthropic.com>
…gsDropdown Replace the group-header Knowledge section with flat "Knowledge Base" / "Knowledge Settings" items separated by dividers. Extract the gear-icon dropdown into a shared SettingsDropdown component and reuse it on the Knowledge page header, consolidating the standalone Documentation, ThemeSwitcher, and admin-gated settings gear into a single dropdown. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…gePage header Remove the Knowledge Settings item from AppHeader's gear dropdown — it's now accessible only via the Knowledge page's own admin-gated settings button. Replace KnowledgePage's SettingsDropdown with a single Tooltip'd Button for direct access. Remove the ?settings=1 deep-link plumbing (shouldAutoOpenKnowledgeSettings, the useEffect watcher, and its tests) since nothing navigates there anymore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Problem
The navbar had accumulated a row of standalone icon buttons over time (Live Events, Knowledge, Documentation, Theme, Settings) alongside search and the user menu. Most of these are setup/reference actions that get used heavily while a workspace is being configured, then rarely afterward — but they were permanently taking up navbar real estate regardless of how often they're actually used. The navbar was visibly cluttered as a result (see board discussion).
Goal
Reduce visual clutter without removing access to anything: fold the low-frequency, non-essential icons into a single entry point (the settings gear), while leaving the user avatar menu — which people reach for constantly — exactly where it is.
Summary
SettingsDropdown(which had Documentation, Theme, and admin-gated Knowledge Settings) with a single admin-gated "Knowledge Base Settings" button that opens the settings modal directly. Documentation and Theme are intentionally removed from this page — the back-arrow leads to the main app where the navbar covers both.?settings=1deep-link plumbing (shouldAutoOpenKnowledgeSettings, itsuseEffectwatcher, and related tests) is deleted — nothing navigates to/knowledge?settings=1anymore.SettingsDropdowncomponent stays in place forAppHeader;KnowledgePageno longer imports it.Follows frontend guidelines: uses vanilla AntD
Dropdown+Menuitems,Button+Tooltip,theme.useToken()for sizing, no new CSS files, no.ant-*overrides.Test plan
tsc --noEmit)build + typecheckpasses (--filter='!@agor/docs')🤖 Generated with Claude Code