feat: preview image attachments in chat#1981
Open
richardfogaca wants to merge 1 commit into
Open
Conversation
Member
|
One potential concern around this is the fact that we might be trying to decouple the daemon with the filesystem. Here this assumes the daemon has access to user's home (as the current destination upload target). Not sure what exactly it means:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Fixes #1975
Summary
Why / context
Uploads currently display only filesystem paths in chat. Image previews make uploaded images convenient to inspect without weakening authorization or changing the agent-visible prompt text.
Implementation notes
Screenshots
Validation / test plan
Screenshots / demos
Manual browser verification completed; no durable screenshot artifact is attached.
Risks / rollout / rollback
The filesystem and authorization surface is protected by bearer authentication, session/task association, and upload-root containment. Roll back by reverting this commit.
Out of scope / follow-ups