Tweak jemalloc configuration - #1204
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
abad7db to
9ac6a87
Compare
This magic line is the result of multiple benchmarks evaluating different configurations for isolated mainnet runs over 10 epochs. This gives a good balance between allocation time and memory management overall. Also, this commit instructs RocksDB to use jemalloc as its allocator, which helps reduce its overall footprint. No-changelog Signed-off-by: KtorZ <matthias.benkort@gmail.com>
| test-case = "3.3.1" | ||
| thiserror = "2.0.19" | ||
| tikv-jemallocator = { version = "0.7.0" } | ||
| tikv-jemallocator = { version = "0.6.1" } |
There was a problem hiding this comment.
Any reason not to use the latest version? Could we add a comment so that it's not updated by accident?
There was a problem hiding this comment.
It's only a dependency issue. Rocksdb "jemalloc" feature only works with 0.6.1; and somehow the solver cannot resolve this and the build just throw an error stating the divergence. So no need for a comment I believe; we should update if we can, but that depends on the rocksdb dependency.
I've also inspected the changelog and there's not much we're missing from 0.7.* anyway.
This magic line is the result of multiple benchmarks evaluating different configurations for isolated mainnet runs over 10 epochs. This gives a good balance between allocation time and memory management overall:
vanilla
background_thread:true,narenas:2,dirty_decay_ms:250,muzzy_decay_ms:0,tcache_max:512
(note that some of sync time is recovered with #1203)