Explicitly close tcp connection in Prometheus test#121
Open
KaitCrawford wants to merge 3 commits into
Open
Conversation
jerith
approved these changes
Dec 15, 2020
jerith
left a comment
jerith
left a comment
Member
There was a problem hiding this comment.
👍 with an optional change mentioned inline. Feel free to merge with or without making the change.
| [sample] = http_requests_total_for_view( | ||
| response.text, 'prometheus-django-metrics') | ||
| assert_that(sample.value, Equals(1.0)) | ||
| response.close() |
Member
There was a problem hiding this comment.
I don't think we need this, given that we already read the whole request body (with response.text above) and all it does is release the connection back to the pool for reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.