Allow editors.List subclasses to define their ListItem class#398
Closed
fonji wants to merge 4 commits intopowmedia:masterfrom
Closed
Allow editors.List subclasses to define their ListItem class#398fonji wants to merge 4 commits intopowmedia:masterfrom
fonji wants to merge 4 commits intopowmedia:masterfrom
Conversation
Collaborator
|
Just curious, for what reason did you want to override List.Item? |
Contributor
Author
|
I'm trying to render a List of inlineNestedForms in bootstrap's tabs. Each object is in a tab. Sorry for not posting the whole story first! |
Collaborator
|
Cool. 👍 |
Collaborator
|
@fonji can you remove the /dist files please ? These are conflicted. Could a test be added to prove that this works too please ? |
Contributor
Author
|
Will do! I'll try to find some time this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm writing a new editor based on List and I need it to use another List.Item class.
I didn't want to override the whole List.Item as I want to be able to use both editors (my extension and the original List).
Here's how I did it. Tests passed successfully on firefox and chromium (and I don't see why it wouldn't).
I wonder if it can be useful to allow to override this in the schema. Let me know what you think.
Have a nice week!