idPrefix is always undefined_#340
Open
adriano-di-giovanni wants to merge 7 commits intopowmedia:masterfrom
Open
idPrefix is always undefined_#340adriano-di-giovanni wants to merge 7 commits intopowmedia:masterfrom
undefined_#340adriano-di-giovanni wants to merge 7 commits intopowmedia:masterfrom
Conversation
…s undefined) to model instance cid
Author
|
I also changed version number and built again for distribution. I did it because I need to consume my fork with bower. Hope it helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendermethod ofForm.editors.NestedModeldefinedthis.nestedFormas follows:Thus,
idPrefixattribute forNestedFormoptions hash was alwaysundefined_.I changed the line
idPrefix: this.id + ' 'toidPrefix: modelInstance.cidin order to have unique field ids.I also built for distribution.
I think it is now correct. If it's not, please feel free to reject my pull request: you won't hurt my feelings :)