-
-
Notifications
You must be signed in to change notification settings - Fork 110
feat: add auto-hmr-plugin and autoHmr option #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds an unplugin-based auto-HMR plugin for Vue Router that detects router declarations, injects a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/auto-hmr/index.ts (1)
77-77: Regex reliability concern.Same issue as line 35 - regex matching in code can be unreliable.
🧹 Nitpick comments (1)
src/auto-hmr/index.ts (1)
35-35: Consider regex reliability.The regex
/handleHotUpdate\([\s\S]*?\)/may match unintended occurrences like comments or strings. Consider using AST-based detection instead.- const handleHotUpdateCallRegex = /handleHotUpdate\([\s\S]*?\)/Use AST parsing to detect function calls more reliably:
function hasHandleHotUpdateCall(ast: any): boolean { // Walk AST to find CallExpression with callee.name === 'handleHotUpdate' }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/auto-hmr/index.ts(1 hunks)src/index.ts(2 hunks)src/options.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/index.ts (2)
src/auto-hmr/index.ts (1)
createAutoHmrPlugin(34-101)src/core/moduleConstants.ts (1)
MODULE_ROUTES_PATH(6-6)
🔇 Additional comments (11)
src/options.ts (1)
216-220: LGTM!Clean addition of the new option with proper documentation.
src/index.ts (2)
24-24: Clean import addition.
206-212: Good integration pattern.Follows the same conditional plugin inclusion pattern as the experimental autoExportsDataLoaders.
src/auto-hmr/index.ts (8)
4-6: Helper function is correct.
8-15: Router detection logic is sound.
17-28: Import detection logic is correct.
42-42: Virtual module filtering is correct.
46-48: Early return optimization is good.
82-86: Import injection looks correct.
89-91: Function call injection is correct.
93-95: Code transformation approach is sound.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This reverts commit 7abc277.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@posva PTAL |
posva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/auto-hmr/index.ts (1)
69-89: Fix the TypeScript type error properly.The
@ts-expect-errorsuppresses a type mismatch. The AST body should be typed correctly rather than using a type suppression comment.Apply this diff to fix:
- // @ts-expect-error - for (const node of ast.body) { + for (const node of ast.body as any[]) {Alternatively, import and use the proper estree types for
Programto typeast.bodycorrectly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/auto-hmr/ast.ts(1 hunks)src/auto-hmr/auto-hmr.spec.ts(1 hunks)src/auto-hmr/index.ts(1 hunks)src/index.ts(2 hunks)src/options.ts(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/index.ts
- src/options.ts
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-16T13:01:42.709Z
Learnt from: posva
Repo: posva/unplugin-vue-router PR: 700
File: src/codegen/generateParamParsers.ts:91-94
Timestamp: 2025-08-16T13:01:42.709Z
Learning: In the unplugin-vue-router codebase, path normalization for import specifiers is handled elsewhere in the system (not at individual call sites like generateParamParsers.ts). Individual functions should not normalize paths themselves as it violates separation of concerns.
Applied to files:
src/auto-hmr/auto-hmr.spec.tssrc/auto-hmr/index.ts
📚 Learning: 2025-08-15T16:11:02.627Z
Learnt from: posva
Repo: posva/unplugin-vue-router PR: 700
File: src/codegen/generateRouteResolver.ts:0-0
Timestamp: 2025-08-15T16:11:02.627Z
Learning: In src/codegen/generateRouteResolver.ts, the user wants comment alignment preserved in the generated resolver code, even when fixing potential runtime errors with String.repeat().
Applied to files:
src/auto-hmr/index.ts
📚 Learning: 2025-08-23T12:49:31.747Z
Learnt from: posva
Repo: posva/unplugin-vue-router PR: 700
File: src/core/tree.ts:313-331
Timestamp: 2025-08-23T12:49:31.747Z
Learning: The regexp getter in src/core/tree.ts correctly processes the root node to add the leading slash. The empty pathSegment from root becomes an empty string when escaped, but the concatenation logic `"" + (re ? '\\/' : '') + re` properly adds the leading slash that routes require.
Applied to files:
src/auto-hmr/index.ts
🧬 Code graph analysis (2)
src/auto-hmr/auto-hmr.spec.ts (1)
src/auto-hmr/index.ts (3)
createAutoHmrPlugin(39-116)transform(54-114)DEFAULT_AUTO_HMR_OPTIONS(30-37)
src/auto-hmr/index.ts (1)
src/auto-hmr/ast.ts (4)
getRouterDeclaration(8-16)nameFromDeclaration(4-6)getHandleHotUpdateDeclaration(18-29)hasHandleHotUpdateCall(31-72)
🔇 Additional comments (9)
src/auto-hmr/auto-hmr.spec.ts (1)
1-754: LGTM! Comprehensive test coverage.The test suite thoroughly covers file filtering, router detection (both
createRouterandexperimental_createRouter), declaration detection, import/call injection logic, and various edge cases. The mock setup is appropriate and the test organization is clear.src/auto-hmr/ast.ts (3)
4-6: LGTM!Clean null-safe extraction of identifier name from declaration.
8-16: LGTM!Correctly identifies router declarations from
createRouterorexperimental_createRoutercalls.
18-29: LGTM!Properly checks for
handleHotUpdateimport from the specified module path.src/auto-hmr/index.ts (5)
11-28: LGTM!Clear interface definition with proper documentation for the auto-HMR options.
30-37: LGTM!Sensible defaults for auto-HMR: targets common router file patterns and uses the standard module path.
43-49: LGTM!Regex pre-filter and file filter setup are efficient and correctly configured.
54-61: LGTM!Proper early returns for virtual modules, non-matching files, and files without
createRoutercalls optimize performance.
91-111: LGTM!The injection logic correctly adds import and call only when needed, avoiding duplicates. Code generation using string concatenation is straightforward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/auto-hmr/ast.ts (1)
56-56: Remove redundant check.Line 35 already verifies
typeof node !== 'object'.- if (typeof node !== 'object') return false - for (const key in node) {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/auto-hmr/ast.ts(1 hunks)
🔇 Additional comments (4)
src/auto-hmr/ast.ts (4)
4-6: LGTM.Clean null-safe implementation.
8-16: LGTM.The AND chain ensures
x.initexists before accessingx.init.calleeon line 12.
18-29: LGTM.The guard on line 20 ensures safe property access on subsequent lines.
31-75: Past review concern addressed.The WeakSet on line 32 now guards against circular references as requested.
|
I made some adjustments to the code. Now the autoHmr function is enabled by default. Users can also configure which files need to be scanned and where to import |
reimpl: #617
This pr is similar to the implementation of vuejs/pinia#2954, which transfers the work of automatically injecting hmr code to the plugin part, and adds an option to control whether the plugin is enabled or not.
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.