Skip to content

Conversation

@cpsievert
Copy link
Collaborator

Closes #219

@cpsievert cpsievert requested a review from Copilot November 11, 2025 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances ContentPDF to preserve URL information when PDFs are loaded from URLs, and updates the Inspect API translation layer to handle both URL and data-based PDFs appropriately.

Key Changes:

  • Added optional url field to ContentPDF class
  • Updated content_pdf_url() to retain the original URL
  • Modified Inspect conversion functions to handle URL-based PDFs without re-encoding

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
chatlas/_content.py Added optional url parameter to ContentPDF class definition and updated docstring
chatlas/_content_pdf.py Modified content_pdf_url() to pass URL to ContentPDF constructor
chatlas/_inspect.py Updated conversion functions to handle URL-based PDFs and avoid unnecessary base64 encoding
chatlas/_provider_openai_completions.py Reordered parameters and expanded docstring to clarify OpenAI-compatible API support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to evaluate datasets that contain Inline pdfs using chatlas to_solver()

2 participants